Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic for IncludePlatformAttributes #51575

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Simplify logic for IncludePlatformAttributes #51575

merged 1 commit into from
Apr 20, 2021

Conversation

jeffhandley
Copy link
Member

Addressing some post-merge feedback on #51450 from @safern: #51450 (comment).

This simplifies a difficult to read condition around when we should include the internal platform support attributes.

@ghost
Copy link

ghost commented Apr 20, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Addressing some post-merge feedback on #51450 from @safern: #51450 (comment).

This simplifies a difficult to read condition around when we should include the internal platform support attributes.

Author: jeffhandley
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeffhandley

@ghost
Copy link

ghost commented Apr 20, 2021

Hello @jeffhandley!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes, a condition that will be fulfilled in about 5 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jeffhandley
Copy link
Member Author

The failing test is #51588.

@jeffhandley jeffhandley merged commit 466deef into dotnet:main Apr 20, 2021
@jeffhandley jeffhandley deleted the jeffhandley/use-supportedosplatforms-feedback branch April 20, 2021 22:30
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants