Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AndroidCrypto] Fix handling of no peer certificates #51316

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Apr 15, 2021

  • Android's SSLSession.getPeerCertificates throws if there are no certs. Treat this as no certs instead of an error.
  • Clear remaining data before closing stream

cc @jkoritzinsky @steveisok @AaronRobinsonMSFT @bartonjs @wfurt

@ghost
Copy link

ghost commented Apr 15, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Android's SSLSession.getPeerCertificates throws if there are no certs. Treat this as no certs instead of an error.
  • Clear remaining data before closing stream
Author: elinor-fung
Assignees: -
Labels:

area-System.Security

Milestone: -

@ghost
Copy link

ghost commented Apr 15, 2021

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Android's SSLSession.getPeerCertificates throws if there are no certs. Treat this as no certs instead of an error.
  • Clear remaining data before closing stream
Author: elinor-fung
Assignees: -
Labels:

area-System.Net.Security, os-android

Milestone: -

@elinor-fung elinor-fung merged commit 52d8c3f into dotnet:main Apr 16, 2021
@elinor-fung elinor-fung deleted the sslFixes-android branch April 16, 2021 00:33
@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants