-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alpine ARM docker image #51099
Merged
janvorli
merged 2 commits into
dotnet:main
from
janvorli:update-alpine-arm-docker-image
Apr 15, 2021
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,9 +66,9 @@ jobs: | |
# Linux musl arm32 | ||
- ${{ if eq(parameters.platform, 'Linux_musl_arm') }}: | ||
- ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
- (Alpine.312.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.12-helix-arm32v7-20200908125213-5bece88 | ||
- (Alpine.313.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.13-helix-arm32v7-20210414141857-1ea6b0a | ||
- ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
- (Alpine.312.Arm32)[email protected]/dotnet-buildtools/prereqs:alpine-3.12-helix-arm32v7-20200908125213-5bece88 | ||
- (Alpine.313.Arm32)[email protected]/dotnet-buildtools/prereqs:alpine-3.13-helix-arm32v7-20210414141857-1ea6b0a | ||
|
||
# Linux musl arm64 | ||
- ${{ if eq(parameters.platform, 'Linux_musl_arm64') }}: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we downgraded to 16.04? This will go out of support this month.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the reason was that cross tools (e.g. crossgen targetting arm, but running on x64) would crash on 16.04 and we also use 16.04 on arm64 musl. I guess that when 16.04 goes out of support, we will need to change all 16.04 based images to 18.04 ones.
Ideally, we would run cross build on CentOS 7, but unfortunately that doesn't work due to some differences in default search paths for libs / headers that are compiled into the llvm tools. I have tried to make it work on CentOS 7 in the past, but I didn't have time to finish it. I'll try to dig out that experimental changes once I get some priority things off my table and see if I can make it work.