-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][libraries] Skip failing Android tests with ActiveIssues and proj level skips #50800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
mdh1418
force-pushed
the
skip_android_library_tests
branch
2 times, most recently
from
April 7, 2021 14:49
33f91c8
to
a53c6ce
Compare
This was referenced Apr 7, 2021
mdh1418
force-pushed
the
skip_android_library_tests
branch
from
April 9, 2021 14:36
3a38d25
to
6c95420
Compare
mdh1418
force-pushed
the
skip_android_library_tests
branch
from
May 5, 2021 15:30
121b6b3
to
11426bd
Compare
….Tests ActiveIssues 37073
…veIssues into 49868
…ts ActiveIssues 50567
…ctiveIssues 50575
…s ActiveIssue 50936
…s.Tests ActiveIssue 50937
…ests test proj skip
…edException related failures
…ests active issue
akoeplinger
approved these changes
May 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In effort to assess the state of the Android library tests, a number of tests will be skipped according to https://www.dropbox.com/scl/fi/hcv75228nu9b070x5sbso/State-of-Android-Library-Tests.paper?dl=0&rlkey=gck1s5hmz32jcom4fo1m7570k#:uid=471929463738166572469040&h2=All-Github-Android-issues-(Tha
Test suites that crash, hang, or have a significant number of failures (mostly 20+ failing unique test methods) across the different architectures of x64, x86, arm64 are skipped on at the
tests.proj
level. Otherwise,[ActiveIssue]
attributes have been attached to either the individual test methods that fail, or the entire class if the whole test class fails. Any pre-existingActiveIssue
attribute associated with Android had been reassessed to either remain or be closed.A few test suites have been skipped because they fail with some form of
PlatformNotSupportedException
.All of the Issues can be tracked at https://github.com/dotnet/runtime/projects/48#column-9236429
The ActiveIssues and
tests.proj
exclusions have been tested on #50095 as well.