Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][libraries] Skip failing Android tests with ActiveIssues and proj level skips #50800

Merged
merged 81 commits into from
May 10, 2021

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Apr 6, 2021

In effort to assess the state of the Android library tests, a number of tests will be skipped according to https://www.dropbox.com/scl/fi/hcv75228nu9b070x5sbso/State-of-Android-Library-Tests.paper?dl=0&rlkey=gck1s5hmz32jcom4fo1m7570k#:uid=471929463738166572469040&h2=All-Github-Android-issues-(Tha

Test suites that crash, hang, or have a significant number of failures (mostly 20+ failing unique test methods) across the different architectures of x64, x86, arm64 are skipped on at the tests.proj level. Otherwise, [ActiveIssue] attributes have been attached to either the individual test methods that fail, or the entire class if the whole test class fails. Any pre-existing ActiveIssue attribute associated with Android had been reassessed to either remain or be closed.

A few test suites have been skipped because they fail with some form of PlatformNotSupportedException.

All of the Issues can be tracked at https://github.com/dotnet/runtime/projects/48#column-9236429

The ActiveIssues and tests.proj exclusions have been tested on #50095 as well.

@mdh1418 mdh1418 requested a review from steveisok April 6, 2021 20:07
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mdh1418 mdh1418 force-pushed the skip_android_library_tests branch 2 times, most recently from 33f91c8 to a53c6ce Compare April 7, 2021 14:49
@mdh1418 mdh1418 force-pushed the skip_android_library_tests branch from 3a38d25 to 6c95420 Compare April 9, 2021 14:36
@mdh1418 mdh1418 force-pushed the skip_android_library_tests branch from 121b6b3 to 11426bd Compare May 5, 2021 15:30
Mitchell Hwang added 22 commits May 5, 2021 11:32
Mitchell Hwang added 24 commits May 5, 2021 11:32
@mdh1418 mdh1418 merged commit 913fdbe into dotnet:main May 10, 2021
@mdh1418 mdh1418 deleted the skip_android_library_tests branch May 10, 2021 15:16
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants