Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Switch to shared LowLevelLock #48928

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[mono] Switch to shared LowLevelLock #48928

merged 1 commit into from
Mar 2, 2021

Conversation

CoffeeFlux
Copy link
Contributor

Fixes #48031

@CoffeeFlux CoffeeFlux marked this pull request as ready for review March 2, 2021 00:30
@CoffeeFlux CoffeeFlux requested a review from marek-safar as a code owner March 2, 2021 00:30
@CoffeeFlux CoffeeFlux requested a review from vargaz March 2, 2021 00:30
@vargaz
Copy link
Contributor

vargaz commented Mar 2, 2021

Maybe get rid of the FeatureSharedLowLevelLock conditional as well ?

@CoffeeFlux CoffeeFlux force-pushed the shared-lowlevellock branch from 2d1791c to 61fef69 Compare March 2, 2021 05:23
@CoffeeFlux
Copy link
Contributor Author

Done, good catch.

@vargaz
Copy link
Contributor

vargaz commented Mar 2, 2021 •
edited
Loading

The old one was added because the new one depended on System.Native i think.

@vargaz vargaz closed this Mar 2, 2021
@vargaz vargaz reopened this Mar 2, 2021
@vargaz vargaz merged commit 4b143df into dotnet:main Mar 2, 2021
@runfoapp runfoapp bot mentioned this pull request Mar 2, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marek-safar marek-safar marek-safar approved these changes

@vargaz vargaz vargaz approved these changes

Assignees
No one assigned
Labels
area-VM-threading-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[mono] Switch to shared implementation of LowLevelLock
4 participants
@CoffeeFlux @vargaz @marek-safar @karelz