Code

WIP: WebSocket Compression#48470

Code

Closed

zlatanov wants to merge 52 commits intodotnet:maindotnet/runtime:mainfrom zlatanov:websocket-compressionzlatanov/runtime:websocket-compressionCopy head branch name to clipboard

+2,683-676

Commits

Commits on Feb 12, 2021

• Initial API changes.

  zlatanov

  committed
  2d72286

• Added inflater / deflater and retargeted the project for each of the supported platforms because we now depend on native API.

  zlatanov

  committed
  3913164

• Websocket sending extracted into a dedicated class so we can implement deflate encoders more naturally.

  zlatanov

  committed
  1a3f8cf

Commits on Feb 14, 2021

• Fixed a bug in the sender implementation where if a non persisted deflate was used and a message were to be sent with multiple frames the implementation would have used seprate deflates for each of…

  Show description for e8499ff
  zlatanov

  committed
  e8499ff

Commits on Feb 15, 2021

• Removed tests that were testing RCV1 flag (per message compression) which is now supported.

  zlatanov

  committed
  c4fdf98

• Added receiver encoders and implementation for per message compression.

  zlatanov

  committed
  224f88e

• Removed unused namespace.

  zlatanov

  committed
  600d0fc

• Fixed decoder state reset to not be called in continuations.

  zlatanov

  committed
  0890bf8

• Calling dispose for receiver.

  zlatanov

  committed
  fb56654

• Removed unncecessary renting of memory when waiting for close message.

  

  Ivan Zlatanov

  committed
  7b3b453

• Removed unused method.

  

  Ivan Zlatanov

  committed
  2584973

• Removed unnecessary null check, because the object is never null.

  

  Ivan Zlatanov

  committed
  7597eb2

Commits on Feb 16, 2021

• Updated websockets tests csproj to reflect that now the websockets has seperate builds for each platform.

  zlatanov

  committed
  a8cba93

• Removed socket listener from a test where we are only testing how the websocket handles incoming data where we could easily just use a memory stream.

  zlatanov

  committed
  e273bf3

• Keep alive interval validated twice when using the existing CreateFromStream method in order to keep the name for the ArgumentException that would happen the same as it was.

  zlatanov

  committed
  e26f044

• The *ContextTakeover properties were interpreted incorrectly.

  zlatanov

  committed
  80bf74d

• Fixed a check where ! (not) was missing.

  zlatanov

  committed
  518740e

• Created basic tests for compression using the examples from RFC. Fixed a few bugs along the way.

  zlatanov

  committed
  d517063

• Simplified the creation of the websocket stream used for testing.

  zlatanov

  committed
  63df73a

• Added duplex end to end test that verifies that client and server compress / decompress messages as expected.

  zlatanov

  committed
  4316bd1

Commits on Feb 17, 2021

• Lighting up websocket compression in client.

  zlatanov

  committed
  398e3d8

Commits on Feb 18, 2021

• Updating the constraints of the MaxWindowBits properties - 8 is no longer a valid window bits value, because the underlying gzip library doesn't really support it.

  zlatanov

  committed
  004c589

• Added more tests and fixed some bugs related to splitting messages in multiple frames and reading with smaller output buffers.

  zlatanov

  committed
  16353ea

• Added cancellation token to tests to avoid cases where something is expected to happen but doesn't and we don't have timeouts.

  zlatanov

  committed
  ed4b069

• Fixed a bug where the receiver would happily ignore per message deflate flag in the header if decoder is not configured.

  zlatanov

  committed
  afd23ef

• Moving ZLibNative to Common so it can be cross compiled alongside Interop.zlib.cs.

  zlatanov

  committed
  f8d1f0e

• Removed custom ZLibNative and using the one which now resides in Common.

  zlatanov

  committed
  8872025

• Small refactoring to make inflate / deflate logic more clear.

  zlatanov

  committed
  a0bba92

Commits on Feb 19, 2021

• Parsing websocket deflate headers allocation free.

  zlatanov

  committed
  7c0c514

• Addressing code style and pr feedback.

  zlatanov

  committed
  148c842

• A few style improvements based on feedback.

  zlatanov

  committed
  f276fbf

• Stream is never null.

  zlatanov

  committed
  6511982

• Fixed a bug in the deflater when incompressible message is being sent.

  zlatanov

  committed
  cb38817

• Added a test that sends / receives uncompressed messages with different sizes. Fixed a bug when receiving 0 byte message. Fixed another bug where the payload length wasn't reduced after receiving n…

  Show description for a7c049a
  zlatanov

  committed
  a7c049a

• Added more tests that test control messages. Fixed a bug in websocket during client initiated close, the server would not respond with close message and the client's close task would hang until tim…

  Show description for 2f11043
  zlatanov

  committed
  2f11043

Commits on Feb 20, 2021

• Fixed definitions in ref assemblies.

  zlatanov

  committed
  7303fe2

• Added links to RFC of each of the websocket deflate properties. Also added explanation why we don't support 8 bits althouh the RFC allows it.

  zlatanov

  committed
  89b7e09

• Addressing PR feedback - always using { } for single line blocks.

  zlatanov

  committed
  108da58

• Moving string literals into constants.

  zlatanov

  committed
  e0f98c3

• Consistent Common links.

  zlatanov

  committed
  c995349

• Fully qualified parameter type in ref assembly.

  zlatanov

  committed
  1c2c470

Commits on Feb 21, 2021

• Fixing failing tests.

  zlatanov

  committed
  172089a

• Added comments in code explaining why we use 9 instead of 8 window bits as minimum.

  zlatanov

  committed
  624405f

• Added struct layout auto for readonly struct.

  zlatanov

  committed
  383b4c9

• Forgot to check _sentCloseFrame flag before trying to wait for server connection close.

  zlatanov

  committed
  da7d050

Commits on Feb 22, 2021

• Replaced RandomNumberGenerator with Random with seed to remove non-determinism from tests.

  zlatanov

  committed
  8d951fc

• Little refactoring of receiver to reduce complexity and make it more readable.

  zlatanov

  committed
  eafbd00

• Replaced unused CancellationTokenSource with a method.

  zlatanov

  committed
  75a5c4f

• Removed unneeded (duplicated) check.

  zlatanov

  committed
  82deae3

• More tests.

  zlatanov

  committed
  2f31feb

• Created test for deflate options in client websocket.

  zlatanov

  committed
  9ba2536

• Fixed wrong test in http listener with websocket.

  zlatanov

  committed
  2099294