Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hardcoded rids for targeting/runtime pks #48459

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 18, 2021

The rids in the 6.0 Preview 1 SDK differ to the hardcoded ones in our repo which caused CLI errors locally.

@ViktorHofer ViktorHofer requested a review from eerhardt February 18, 2021 16:01
@ghost
Copy link

ghost commented Feb 18, 2021

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

The rids in the 6.0 Preview 1 SDK differ to the hardcoded ones in our repo which caused CLI errors locally.

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@dotnet dotnet deleted a comment from dotnet-issue-labeler bot Feb 18, 2021
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little question. LGTM

eng/targetingpacks.targets Show resolved Hide resolved
@ViktorHofer
Copy link
Member Author

@safern @hoyosjs looks like there's a race which causes the runtime tests leg trying to download assets that haven't yet been published?

@ViktorHofer ViktorHofer merged commit dcacc4d into master Feb 20, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch February 20, 2021 12:18
@safern
Copy link
Member

safern commented Feb 22, 2021

@safern @hoyosjs looks like there's a race which causes the runtime tests leg trying to download assets that haven't yet been published?

Yeah, that's a known issue. That should require: #43952 in order to be fixed, or calculate the set of dependencies correctly for Mono runtime tests. @naricc do you have an update on that issue?

@@ -15,15 +19,15 @@
LatestRuntimeFrameworkVersion="$(ProductVersion)"
RuntimeFrameworkName="$(SharedFrameworkName)"
RuntimePackNamePatterns="$(SharedFrameworkName).Runtime.**RID**"
RuntimePackRuntimeIdentifiers="linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86;ios-arm64;ios-arm;ios-x64;ios-x86;tvos-arm64;tvos-x64;android-arm64;android-arm;android-x64;android-x86;browser-wasm"
RuntimePackRuntimeIdentifiers="linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86;linux-musl-arm;ios-arm64;ios-arm;ios-x64;ios-x86;tvos-arm64;tvos-x64;android-arm64;android-arm;android-x64;android-x86;browser-wasm;osx-arm64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the SDK have a property that exposes the RIDs that it supports?

@naricc
Copy link
Contributor

naricc commented Feb 22, 2021

@safern As we discussed in the issue, we decided the best way to do it build a corerun that uses mono. I will be working on that next week.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants