-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hardcoded rids for targeting/runtime pks #48459
Conversation
Tagging subscribers to this area: @ViktorHofer Issue DetailsThe rids in the 6.0 Preview 1 SDK differ to the hardcoded ones in our repo which caused CLI errors locally.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little question. LGTM
Yeah, that's a known issue. That should require: #43952 in order to be fixed, or calculate the set of dependencies correctly for Mono runtime tests. @naricc do you have an update on that issue? |
@@ -15,15 +19,15 @@ | |||
LatestRuntimeFrameworkVersion="$(ProductVersion)" | |||
RuntimeFrameworkName="$(SharedFrameworkName)" | |||
RuntimePackNamePatterns="$(SharedFrameworkName).Runtime.**RID**" | |||
RuntimePackRuntimeIdentifiers="linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86;ios-arm64;ios-arm;ios-x64;ios-x86;tvos-arm64;tvos-x64;android-arm64;android-arm;android-x64;android-x86;browser-wasm" | |||
RuntimePackRuntimeIdentifiers="linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86;linux-musl-arm;ios-arm64;ios-arm;ios-x64;ios-x86;tvos-arm64;tvos-x64;android-arm64;android-arm;android-x64;android-x86;browser-wasm;osx-arm64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the SDK have a property that exposes the RIDs that it supports?
@safern As we discussed in the issue, we decided the best way to do it build a corerun that uses mono. I will be working on that next week. |
The rids in the 6.0 Preview 1 SDK differ to the hardcoded ones in our repo which caused CLI errors locally.