[browser] Bump emscripten 2.0.14 #48450

kjpou1 · 2021-02-18T09:09:52Z

Active issue opened on emcripten : emscripten-core/emscripten#13547
PR open here: emscripten-core/emscripten#13549

Emscripten now builds a complete sysroot inside the EM_CACHE directory. Introduced in 2.0.13

This includes the system headers which get copied into place there rather than adding a sequence of extra include directories.

Add -s TEXTDECODER=1 to EMCC_FLAGS to work around bug introduced

Default to TEXTDECODER=2 in -Oz builds to save 0.5KB-1KB of build output size. Default to TEXTDECODER=2 in -Oz builds emscripten-core/emscripten#13304
Fixes TextDecoder is not defined problem with running in console as well as when running the AOT console sample.

ReferenceError: TextDecoder is not defined
    at dotnet.js:1:8517
    at loadScript (runtime.js:196:3)
    at runtime.js:280:1

runtime.js:196: Error executing file
                load (url);

Fixes TextDecoder is not defined problem when running tests in console.

info: ReferenceError: TextDecoder is not defined
  info:     at dotnet.js:1:8517
  info:     at loadScript (runtime.js:196:3)
  info:     at runtime.js:280:1
  info:
  info: runtime.js:196: Error executing file
  info:                 load (url);
  info:   ^
  info:
  info: 09:54:03.1461730 Process v8 exited with 1

- This includes the system headers which get copied into place there rather than adding a sequence of extra include directories.

* Default to TEXTDECODER=2 in -Oz builds to save 0.5KB-1KB of build output size. emscripten-core/emscripten#13304 * Fixes `TextDecoder is not defined` problem with running in console as well as when running the AOT console sample. ``` ReferenceError: TextDecoder is not defined at dotnet.js:1:8517 at loadScript (runtime.js:196:3) at runtime.js:280:1 runtime.js:196: Error executing file load (url); ``` * Fixes `TextDecoder is not defined` problem when running tests in console. ``` info: ReferenceError: TextDecoder is not defined info: at dotnet.js:1:8517 info: at loadScript (runtime.js:196:3) info: at runtime.js:280:1 info: info: runtime.js:196: Error executing file info: load (url); info: ^ info: info: 09:54:03.1461730 Process v8 exited with 1 ```

ghost · 2021-02-18T09:09:58Z

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Emscripten now builds a complete sysroot inside the EM_CACHE directory. Introduced in 2.0.13

This includes the system headers which get copied into place there rather than adding a sequence of extra include directories.

Add -s TEXTDECODER=0 to EMCC_FLAGS to work around bug introduced

Default to TEXTDECODER=2 in -Oz builds to save 0.5KB-1KB of build output size. Default to TEXTDECODER=2 in -Oz builds emscripten-core/emscripten#13304
Fixes TextDecoder is not defined problem with running in console as well as when running the AOT console sample.

ReferenceError: TextDecoder is not defined
    at dotnet.js:1:8517
    at loadScript (runtime.js:196:3)
    at runtime.js:280:1

runtime.js:196: Error executing file
                load (url);

Fixes TextDecoder is not defined problem when running tests in console.

info: ReferenceError: TextDecoder is not defined
  info:     at dotnet.js:1:8517
  info:     at loadScript (runtime.js:196:3)
  info:     at runtime.js:280:1
  info:
  info: runtime.js:196: Error executing file
  info:                 load (url);
  info:   ^
  info:
  info: 09:54:03.1461730 Process v8 exited with 1

Author:	kjpou1
Assignees:	-
Labels:	`area-VM-meta-mono`
Milestone:	-

ghost · 2021-02-18T09:23:22Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Emscripten now builds a complete sysroot inside the EM_CACHE directory. Introduced in 2.0.13

This includes the system headers which get copied into place there rather than adding a sequence of extra include directories.

Add -s TEXTDECODER=0 to EMCC_FLAGS to work around bug introduced

Default to TEXTDECODER=2 in -Oz builds to save 0.5KB-1KB of build output size. Default to TEXTDECODER=2 in -Oz builds emscripten-core/emscripten#13304
Fixes TextDecoder is not defined problem with running in console as well as when running the AOT console sample.

ReferenceError: TextDecoder is not defined
    at dotnet.js:1:8517
    at loadScript (runtime.js:196:3)
    at runtime.js:280:1

runtime.js:196: Error executing file
                load (url);

Fixes TextDecoder is not defined problem when running tests in console.

info: ReferenceError: TextDecoder is not defined
  info:     at dotnet.js:1:8517
  info:     at loadScript (runtime.js:196:3)
  info:     at runtime.js:280:1
  info:
  info: runtime.js:196: Error executing file
  info:                 load (url);
  info:   ^
  info:
  info: 09:54:03.1461730 Process v8 exited with 1

Author:	kjpou1
Assignees:	kjpou1
Labels:	`arch-wasm`, `area-VM-meta-mono`
Milestone:	Future

kjpou1 · 2021-02-18T09:26:46Z

Actually thinking this should be TEXTDECODER=1 and not TEXTDECODER=0

TextDecoder is enabled by default, but it is not always used, because it is slower decoding short strings compared to using a manually rolled JavaScript implementation, which is why the current default TEXTDECODER=1 manually decodes short strings, and falls back to TextDecoder for long strings (cutoff is at 16 byte strings).

Also in multithreaded builds TextDecoder cannot be used because .decode() may not allow SAB. The spec was changed at whatwg/encoding#172 to allow it, but it was done in a way that is making hard to have any visibility as to when each browser would have shipped the update. (when we do, we can drop the TEXTDECODER does not support USE_PTHREADS case in the compiler)

…g introduced - TextDecoder is enabled by default, but it is not always used, because it is slower decoding short strings compared to using a manually rolled JavaScript implementation, which is why the current default `TEXTDECODER=1` manually decodes short strings, and falls back to TextDecoder for long strings (cutoff is at 16 byte strings).

akoeplinger

looks good but we'll need to wait and bump to the new Docker image once it's available.

src/mono/wasm/Makefile

…bump-empscripten-fourteen

kjpou1 · 2021-02-19T06:49:30Z

Seems to be issues with System.IO.FileSystem.CopyFile with upgrade to 2.0.13 as well.

System.IO.FileNotFoundException : Unable to find the specified file.

Looking into the cause of change or report issue

kjpou1 · 2021-02-19T10:59:53Z

Have been able to track the failure to pal_io.c in the copying of the metadata.

With 2.0.12 this returns 0 whereas 2.0.13 returns -1 and errno = 44.

This happened in 2.0.13 so that narrows it down.

…asm-bump-empscripten-fourteen' of https://github.com/kjpou1/runtime into wasm-bump-empscripten-fourteen

kjpou1 · 2021-02-22T06:28:34Z

This PR is the breaking change: emscripten-core/emscripten#13282

kjpou1 · 2021-02-22T09:59:43Z

Created issue: emscripten-core/emscripten#13547

kjpou1 added 3 commits February 18, 2021 09:40

Emscripten now builds a complete sysroot inside the EM_CACHE directory.

91ec839

- This includes the system headers which get copied into place there rather than adding a sequence of extra include directories.

Bump to 2.0.14

21660a9

kjpou1 requested a review from marek-safar as a code owner February 18, 2021 09:09

dotnet-issue-labeler bot added the area-VM-meta-mono label Feb 18, 2021

kjpou1 requested review from vargaz and akoeplinger February 18, 2021 09:10

kjpou1 self-assigned this Feb 18, 2021

kjpou1 added this to the Future milestone Feb 18, 2021

marek-safar requested a review from lewing February 18, 2021 09:18

kjpou1 added the arch-wasm WebAssembly architecture label Feb 18, 2021

kjpou1 marked this pull request as draft February 18, 2021 09:27

kjpou1 mentioned this pull request Feb 18, 2021

[browser] Bump emscripten to 2.0.14. dotnet/dotnet-buildtools-prereqs-docker#410

Merged

kjpou1 marked this pull request as ready for review February 18, 2021 10:07

akoeplinger reviewed Feb 18, 2021

View reviewed changes

src/mono/wasm/Makefile Show resolved Hide resolved

vargaz approved these changes Feb 18, 2021

View reviewed changes

kjpou1 added 2 commits February 18, 2021 17:48

Update platform-matrix.yml with docker image

d9c9d59

Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…

4a29523

…bump-empscripten-fourteen

Merge branch 'master' of https://github.com/dotnet/runtime; branch 'w…

00769ea

…asm-bump-empscripten-fourteen' of https://github.com/kjpou1/runtime into wasm-bump-empscripten-fourteen

kjpou1 added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 22, 2021

akoeplinger mentioned this pull request Feb 23, 2021

Rollback to 2.0.12 until fixes go in dotnet/dotnet-buildtools-prereqs-docker#414

Merged

lewing closed this Feb 24, 2021

ghost locked as resolved and limited conversation to collaborators Mar 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[browser] Bump emscripten 2.0.14 #48450

[browser] Bump emscripten 2.0.14 #48450

kjpou1 commented Feb 18, 2021 •

edited

Loading

ghost commented Feb 18, 2021

ghost commented Feb 18, 2021

kjpou1 commented Feb 18, 2021 •

edited

Loading

akoeplinger left a comment •

edited

Loading

kjpou1 commented Feb 19, 2021

kjpou1 commented Feb 19, 2021 •

edited

Loading

kjpou1 commented Feb 22, 2021

kjpou1 commented Feb 22, 2021

[browser] Bump emscripten 2.0.14 #48450

[browser] Bump emscripten 2.0.14 #48450

Conversation

kjpou1 commented Feb 18, 2021 • edited Loading

ghost commented Feb 18, 2021

ghost commented Feb 18, 2021

kjpou1 commented Feb 18, 2021 • edited Loading

akoeplinger left a comment • edited Loading

Choose a reason for hiding this comment

kjpou1 commented Feb 19, 2021

kjpou1 commented Feb 19, 2021 • edited Loading

kjpou1 commented Feb 22, 2021

kjpou1 commented Feb 22, 2021

kjpou1 commented Feb 18, 2021 •

edited

Loading

kjpou1 commented Feb 18, 2021 •

edited

Loading

akoeplinger left a comment •

edited

Loading

kjpou1 commented Feb 19, 2021 •

edited

Loading