[release/5.0] Split lock to prevent deadlock in Http2Stream. #47921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Http2Connection.ChangeInitialWindowSize locks connection's SyncObject and calls Http2Stream.OnWindowUpdate which locks stream's SyncObject. Http2Stream.Complete is called only while stream's SyncObject lock is take and then it calls Http2Connection.RemoveStream that locks connection SyncObject.
…andler/Http2Stream.cs Co-authored-by: Stephen Toub <[email protected]>
ManickaP
added
the
NO-MERGE
stephentoub
approved these changes
Feb 5, 2021
ManickaP
removed
the
NO-MERGE
geoffkizer
approved these changes
Feb 14, 2021
jeffschwMSFT
approved these changes
Feb 18, 2021
jeffschwMSFT
removed
the
Servicing-consider
Anipik
added
Servicing-approved
|
@Anipik this was approved in email. Can we merge? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #47769 to release/5.0
Fixes #48220
Deadlock within HTTP/2.
/cc @ManickaP
Customer Impact
Reported by Notification Hubs Azure team after an upgrade to .NET 5.0
Regression?
Based on code investigation it has been present in .NET Core 3.1.
However, the customer didn't observer the problem on .NET Core 3.1. This might be due to the fact they had much lower load before moving to .NET 5.0.
Testing
Risk
Low