Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MemoryMarshal.CreateReadOnlySpanFromNullTerminated #47539

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Add MemoryMarshal.CreateReadOnlySpanFromNullTerminated #47539

merged 1 commit into from
Jan 30, 2021

Conversation

stephentoub
Copy link
Member

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@stephentoub stephentoub force-pushed the spanterminated branch 2 times, most recently from cbc90a1 to 4888b01 Compare January 27, 2021 21:15
ahsonkhan
ahsonkhan reviewed Jan 27, 2021
View reviewed changes
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs
Comment on lines +220 to +221
/// <returns>A span representing the specified reference and length.</returns>
/// <remarks>The lifetime of the returned span will not be validated for safety by span-aware languages.</remarks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd want to port these changes to the actual docs site.
https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.memorymarshal.createspan?view=net-5.0

cc @carlossanlop

@runfoapp runfoapp bot mentioned this pull request Jan 28, 2021
Closed
@runfoapp runfoapp bot mentioned this pull request Jan 29, 2021
Closed
@stephentoub
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@stephentoub
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephentoub stephentoub merged commit a10c2e6 into dotnet:master Jan 30, 2021
@stephentoub stephentoub deleted the spanterminated branch January 30, 2021 03:42
@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

@jkotas jkotas jkotas approved these changes

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

Assignees
No one assigned
Labels
area-System.Memory new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Proposal: Span<char> from null-terminated char*
4 participants
@stephentoub @GrabYourPitchforks @ahsonkhan @jkotas