Mono: support CallConvSuppressGCTransition #47006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add suppress_gc_transition bit to MonoMethodSignature to add support for the SuppressGCTransition unmanaged calling convention modifier.
This adds support for `delegate* unmanaged[Cdecl, SuppressGCTransition] <TRet, TArgs...>` function pointers. (And other base calling conventions other than Cdecl).
…er_indirect This was already used by C++/CLI, so the C# function pointers spec allows blittable types in unmanaged function pointer types.
lambdageek
requested review from
CoffeeFlux,
SamMonoRT,
thaystg and
vargaz
as code owners
7 tasks
|
Don't forget to re-enable the SuppressGCTransition runtime test test. It's disabled in issues.targets. |
Done. It's the last commit in the PR 😁 |
vargaz
reviewed
Jan 14, 2021
| @@ -3688,13 +3688,19 @@ mono_marshal_get_native_func_wrapper_indirect (MonoClass *caller_class, MonoMeth | |||
| g_assert (!sig->hasthis && ! sig->explicit_this); | |||
| g_assert (!sig->is_inflated && !sig->has_type_parameters); | |||
|
|
|||
| #if 0 | |||
| /* | |||
There was a problem hiding this comment.
How can non-blittable types be passed to unmanaged code, how are they marshalled ?
There was a problem hiding this comment.
(I'm going by what I see in #46402 (comment))
It works the same way as a normal pinvoke: the wrapper does marshalling based on the managed signature. we don't know the exact callee, but we know the types.
vargaz
approved these changes
Jan 14, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse modopt encoded calling conventions
Add
suppress_gc_transitionbit toMonoMethodSignatureto add support for theSuppressGCTransitionunmanaged calling convention modifier.Don't emit a wrapper on
calliifsuppress_gc_transitionis setThis adds support for
delegate* unmanaged[Cdecl, SuppressGCTransition] <TRet, TArgs...>function pointers. (And other base calling conventions other than Cdecl).Allow blittable types in
mono_marshal_get_native_func_wrapper_indirectThis was already used by C++/CLI, so the C# function pointers spec allows blittable types in unmanaged function pointer types.
Remove SuppressGCTransitionTest from exclude list
Fixes #46451, Contributes to #38480