Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the CoreCLR cross targeting files when dumping to disk. #46394

Merged

Conversation

jkoritzinsky
Copy link
Member

Contributes to #46369

@jkoritzinsky jkoritzinsky added this to the 6.0.0 milestone Dec 24, 2020
Copy link
Contributor

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed the issue in my local build

Thanks @jkoritzinsky

@ghost
Copy link

ghost commented Dec 24, 2020

Hello @sdmaclea!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@sdmaclea sdmaclea merged commit 007f6b9 into dotnet:master Dec 25, 2020
@jkoritzinsky jkoritzinsky deleted the fix-cross-target-publish-to-disk branch January 21, 2021 19:29
@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants