Use Centos8 instead Centos7 for Helix tests

[wfurt]

I updated tests runs to use Centos8 instead of Centos7.
I keept RedHat7 in place.
With that we should be able to get better test coverage.
(even if now running only in container)

fixes #972

[ghost]

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I updated tests runs to use Centos8 instead of Centos7.
I keept RedHat7 in place.
With that we should be able to get better test coverage.
(even if now running only in container)

fixes #972

Author:	wfurt
Assignees:	-
Labels:	area-Infrastructure
Milestone:	-

[jkoritzinsky]

Given that CentOS 8 goes out of support in under a year, do we want to move the RedHat 7 leg to RedHat 8 and keep the CentOS leg at CentOS 7?

[wfurt]

we may eventually. But there is are still some lingering questions about ARM and year it long time. Getting Centos 8 into container was fastest and easiest for now to get at least some coverage.

[wfurt]

/root/helix/work/workitem /root/helix/work/workitem
Process terminated. Couldn't find a valid ICU package installed on the system. Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.
   at System.Environment.FailFast(System.String)
   at System.Globalization.GlobalizationMode.GetGlobalizationInvariantMode()

The image seems to have issue with globalization @MattGal . I'll take a look tomorrow.

[MattGal]

LGTM, assuming the tests pass on the updated OS.

[MattGal]

Looks like the image or a test needs to be updated for OpenSSL stuff:

    System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientNoEncryption_ConnectWithNoEncryption [FAIL]
      Assert.IsType() Failure
      Expected: System.PlatformNotSupportedException
      Actual:   Interop+OpenSsl+SslException
      Stack Trace:
        /_/src/libraries/System.Net.Security/tests/FunctionalTests/ServerNoEncryptionTest.cs(99,0): at System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientNoEncryption_ConnectWithNoEncryption()
        --- End of stack trace from previous location ---
    System.Net.Security.Tests.ServerAllowNoEncryptionTest.ServerAllowNoEncryption_ClientNoEncryption_ConnectWithNoEncryption [SKIP]
      Condition(s) not met: "SupportsNullEncryption"
  Finished:    System.Net.Security.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Security.Tests  Total: 4832, Errors: 0, Failed: 1, Skipped: 8, Time: 23.954s
/root/helix/work/workitem
----- end Fri Dec 18 23:59:13 UTC 2020 ----- exit code 1 ----------------------------------------------------------

[tmds]

👍 for adding a CentOS 8 build to increase coverage.
We can see how things evolve with CentOS 8 Stream, and decide to adopt Stream or use RHEL 8 instead later.

cc @omajid

[wfurt]

CI all clean now to get some test coverage. We can make updates later as we see fit.