Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move msbuild tasks into src folder and delete dead code #45722

Merged
merged 7 commits into from
Dec 8, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Dec 7, 2020

Contributes to #36519

We'll always have a need for repository local msbuild tasks. As the tools-local folder only clutters the repository root, moving them into the src folder should be a better place.

Also deleting dead task code.

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer ViktorHofer changed the title Move msbuild tasks into src folder Move msbuild tasks into src folder and delete dead code Dec 7, 2020
@ghost
Copy link

ghost commented Dec 7, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #36519

We'll always have a need for repository local msbuild tasks. As the tools-local folder only clutters the repository root, moving them into the src folder should be a better place.

Also deleting dead task code.

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@ViktorHofer ViktorHofer self-assigned this Dec 7, 2020
@ViktorHofer
Copy link
Member Author

Someone pls approve so that I can merge the PR tomorrow morning ;)

@marek-safar
Copy link
Contributor

src\tasks sounds a bit strange to me, did you think about placing them under src\msbuild\tasks

@ViktorHofer
Copy link
Member Author

We don't have a parent msbuild folder anywhere else, neither in eng which mostly contains msbuild files, nor in src libraries. As our primary build engine is msbuild, I don't think we need the extra msbuild folder. Or let me rephrase, what else would we put there? Other pure msbuild files like Directory.Build.props/targets/rsp actually can't be in a subfolder, otherwise they wouldn't apply.

@marek-safar
Copy link
Contributor

it's just not obvious to me that src/tasks is about in-tree msbuild tasks support but I can live with that

@ViktorHofer
Copy link
Member Author

it's just not obvious to me that src/tasks is about in-tree msbuild tasks support but I can live with that

I will add a README.md to make that clear. Thanks for the feedback.

@ViktorHofer ViktorHofer merged commit e35526f into dotnet:master Dec 8, 2020
@ViktorHofer ViktorHofer deleted the Tasks branch December 8, 2020 12:31
@ViktorHofer
Copy link
Member Author

Submitted #45754

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants