-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move msbuild tasks into src folder and delete dead code #45722
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @ViktorHofer Issue DetailsContributes to #36519 We'll always have a need for repository local msbuild tasks. As the tools-local folder only clutters the repository root, moving them into the src folder should be a better place. Also deleting dead task code.
|
.../Microsoft.NET.Runtime.Android.Sample.Mono/Microsoft.NET.Runtime.Android.Sample.Mono.pkgproj
Outdated
Show resolved
Hide resolved
Someone pls approve so that I can merge the PR tomorrow morning ;) |
|
We don't have a parent msbuild folder anywhere else, neither in eng which mostly contains msbuild files, nor in src libraries. As our primary build engine is msbuild, I don't think we need the extra msbuild folder. Or let me rephrase, what else would we put there? Other pure msbuild files like Directory.Build.props/targets/rsp actually can't be in a subfolder, otherwise they wouldn't apply. |
it's just not obvious to me that |
I will add a README.md to make that clear. Thanks for the feedback. |
Submitted #45754 |
Contributes to #36519
We'll always have a need for repository local msbuild tasks. As the tools-local folder only clutters the repository root, moving them into the src folder should be a better place.
Also deleting dead task code.