-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable ReadWrite_Success_Large test for CryptoStream because it takes too long to run #45081
disable ReadWrite_Success_Large test for CryptoStream because it takes too long to run #45081
Conversation
…s too long to run
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley Issue DetailsThis test is from the Stream Conformance Tests. It takes >120s to run, compared to ~2s for the rest of the test suite. Underlying product issue is tracked in #45080 cc @stephentoub
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
[Theory] | ||
[MemberData(nameof(ReadWrite_Success_Large_MemberData))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Theory] | |
[MemberData(nameof(ReadWrite_Success_Large_MemberData))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes XUnit complain: error xUnit1013: Public method 'ReadWrite_Success_Large' on test class 'ConnectedStreamConformanceTests' should be marked as a Theory.
Interestingly, XUnit is actually complaining about the wrong class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do the same thing elsewhere, e.g.
Lines 24 to 36 in bf302de
// TODO: These are all hanging, likely due to Stream close behavior. | |
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")] | |
public override Task Read_Eof_Returns0(ReadWriteMode mode, bool dataAvailableFirst) => base.Read_Eof_Returns0(mode, dataAvailableFirst); | |
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")] | |
public override Task CopyToAsync_AllDataCopied(int byteCount, bool useAsync) => base.CopyToAsync_AllDataCopied(byteCount, useAsync); | |
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")] | |
public override Task CopyToAsync_AllDataCopied_Large(bool useAsync) => base.CopyToAsync_AllDataCopied_Large(useAsync); | |
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")] | |
public override Task Dispose_ClosesStream(int disposeMode) => base.Dispose_ClosesStream(disposeMode); | |
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")] | |
public override Task Write_DataReadFromDesiredOffset(ReadWriteMode mode) => base.Write_DataReadFromDesiredOffset(mode); | |
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")] | |
public override Task Parallel_ReadWriteMultipleStreamsConcurrently() => base.Parallel_ReadWriteMultipleStreamsConcurrently(); |
I would need to try it locally to know why this is different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Strange.
This test is from the Stream Conformance Tests.
It takes >120s to run, compared to ~2s for the rest of the test suite.
Underlying product issue is tracked in #45080
cc @stephentoub