Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ReadWrite_Success_Large test for CryptoStream because it takes too long to run #45081

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

geoffkizer
Copy link
Contributor

This test is from the Stream Conformance Tests.

It takes >120s to run, compared to ~2s for the rest of the test suite.

Underlying product issue is tracked in #45080

cc @stephentoub

@ghost
Copy link

ghost commented Nov 22, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Issue Details

This test is from the Stream Conformance Tests.

It takes >120s to run, compared to ~2s for the rest of the test suite.

Underlying product issue is tracked in #45080

cc @stephentoub

Author: geoffkizer
Assignees: -
Labels:

area-System.Security

Milestone: 6.0.0

@geoffkizer
Copy link
Contributor Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Comment on lines +32 to +33
[Theory]
[MemberData(nameof(ReadWrite_Success_Large_MemberData))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Theory]
[MemberData(nameof(ReadWrite_Success_Large_MemberData))]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes XUnit complain: error xUnit1013: Public method 'ReadWrite_Success_Large' on test class 'ConnectedStreamConformanceTests' should be marked as a Theory.

Interestingly, XUnit is actually complaining about the wrong class.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do the same thing elsewhere, e.g.

// TODO: These are all hanging, likely due to Stream close behavior.
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
public override Task Read_Eof_Returns0(ReadWriteMode mode, bool dataAvailableFirst) => base.Read_Eof_Returns0(mode, dataAvailableFirst);
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
public override Task CopyToAsync_AllDataCopied(int byteCount, bool useAsync) => base.CopyToAsync_AllDataCopied(byteCount, useAsync);
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
public override Task CopyToAsync_AllDataCopied_Large(bool useAsync) => base.CopyToAsync_AllDataCopied_Large(useAsync);
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
public override Task Dispose_ClosesStream(int disposeMode) => base.Dispose_ClosesStream(disposeMode);
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
public override Task Write_DataReadFromDesiredOffset(ReadWriteMode mode) => base.Write_DataReadFromDesiredOffset(mode);
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
public override Task Parallel_ReadWriteMultipleStreamsConcurrently() => base.Parallel_ReadWriteMultipleStreamsConcurrently();

I would need to try it locally to know why this is different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Strange.

@stephentoub stephentoub merged commit e8c4f22 into dotnet:master Nov 23, 2020
@geoffkizer geoffkizer deleted the disableslowcryptostreamtest branch November 24, 2020 19:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants