Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement getMethodModule #45046

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Implement getMethodModule #45046

merged 1 commit into from
Nov 21, 2020

Conversation

BruceForstall
Copy link
Member

R2R testing was failing by hitting an assert about unimplemented
getMethodModule, called as part of R2R-only devirtualization handling
in the JIT.

I didn't determine why this regressed now.

Fixes #45016

@BruceForstall
Implement getMethodModule
fffc9ea 
R2R testing was failing by hitting an assert about unimplemented
getMethodModule, called as part of R2R-only devirtualization handling
in the JIT.

I didn't determine why this regressed now.

Fixes dotnet#45016
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 21, 2020
@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib PTAL -- this fixes outerloop testing

@BruceForstall BruceForstall merged commit 8a3dc16 into dotnet:master Nov 21, 2020
@BruceForstall BruceForstall deleted the ImplementSpmiGetMethodModule branch November 21, 2020 18:46
@BruceForstall
Copy link
Member Author

I believe the failure was a regression introduced by #44834, because SuperPMI now applies to NGEN, whereas before we only set COMPlus_AltJit=* and not COMPlus_AltJitNgen=* for the shim, so crossgen wasn't getting collected.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

superpmicollect test failing in R2R x64 outerloop testing
3 participants
@BruceForstall @AndyAyersMS @Dotnet-GitSync-Bot