Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OutputRid for host packs #45041

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Use OutputRid for host packs #45041

merged 1 commit into from
Nov 21, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 21, 2020

cc @safern, we get the following output in linux-musl-arm64 container:

expand 
  [ 98%] Building CXX object cli/apphost/static/CMakeFiles/singlefilehost.dir/__/__/__/corehost.cpp.o
  [ 99%] Linking CXX shared library libhostpolicy.so
  Stripping symbols from $<TARGET_FILE:hostpolicy> into file $<TARGET_FILE:hostpolicy>.dbg
  [ 99%] Linking CXX shared library libhostfxr.so
  [ 99%] Built target hostpolicy
  Stripping symbols from $<TARGET_FILE:hostfxr> into file $<TARGET_FILE:hostfxr>.dbg
  [ 99%] Built target hostfxr
  [100%] Linking CXX executable singlefilehost
  Stripping symbols from $<TARGET_FILE:singlefilehost> into file $<TARGET_FILE:singlefilehost>.dbg
  [100%] Built target singlefilehost
  Install the project...
  -- Install configuration: "RELEASE"
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/singlefilehost.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/singlefilehost
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/apphost.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/apphost
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/dotnet.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/dotnet
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/coreclr_delegates.h
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/hostfxr.h
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/nethost.h
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libnethost.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libnethost.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libnethost.a
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/test_fx_ver
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostfxr.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostfxr.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostpolicy.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost/libhostpolicy.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockcoreclr.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockcoreclr.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostfxr_2_2.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostfxr_2_2.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostpolicy.so.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/libmockhostpolicy.so
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/nativehost.dbg
  -- Installing: /runtime/artifacts/bin/linux-musl-arm64.Release/corehost_test/nativehost
  Microsoft.NETCore.DotNetHost -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHost.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostPolicy -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostResolver.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHost -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHost.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostPolicy -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostPolicy.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostResolver.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetAppHost -> /runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetAppHost.6.0.0-dev.nupkg
  Microsoft.NETCore.DotNetAppHost -> /runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetAppHost.6.0.0-dev.nupkg
  Microsoft.NETCore.App.Ref -> 
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-dev.symbols.nupkg'.
  Microsoft.NETCore.App.Runtime -> 
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-dev.symbols.nupkg'.
  Microsoft.NETCore.App.Host -> 
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-dev.symbols.nupkg'.
  Microsoft.NETCore.App.Crossgen2 -> 
  dotnet-host -> 
  dotnet-hostfxr -> 
  dotnet-runtime-deps-centos.7 -> 
  dotnet-runtime-deps-debian -> 
  dotnet-runtime-deps-fedora.27 -> 
  dotnet-runtime-deps-opensuse.42 -> 
  dotnet-runtime-deps-oraclelinux.7 -> 
  dotnet-runtime-deps-rhel.7 -> 
  dotnet-runtime-deps-sles.12 -> 
  Microsoft.NETCore.App.Bundle -> 
  Microsoft.NET.HostModel -> /runtime/artifacts/bin/Microsoft.NET.HostModel/Release/netstandard2.0/Microsoft.NET.HostModel.dll
  Successfully created package '/runtime/artifacts/packages/Release/NonShipping/Microsoft.NET.HostModel.6.0.0-dev.nupkg'.
  Successfully created package '/runtime/artifacts/packages/Release/NonShipping/Microsoft.NET.HostModel.6.0.0-dev.symbols.nupkg'.
  TestUtils -> /runtime/artifacts/bin/TestUtils/Release/net6.0/TestUtils.dll
  Microsoft.NET.HostModel.ComHost.Tests -> /runtime/artifacts/bin/Microsoft.NET.HostModel.ComHost.Tests/Release/net6.0/Microsoft.NET.HostModel.ComHost.Tests.dll
  Microsoft.DotNet.CoreSetup.Packaging.Tests -> /runtime/artifacts/bin/Microsoft.DotNet.CoreSetup.Packaging.Tests/Release/net6.0/Microsoft.DotNet.CoreSetup.Packaging.Tests.dll
  BundleHelper -> /runtime/artifacts/bin/BundleHelper/Release/net6.0/BundleHelper.dll
  Microsoft.NET.HostModel.AppHost.Tests -> /runtime/artifacts/bin/Microsoft.NET.HostModel.AppHost.Tests/Release/net6.0/Microsoft.NET.HostModel.AppHost.Tests.dll
  HostActivation.Tests -> /runtime/artifacts/bin/HostActivation.Tests/Release/net6.0/HostActivation.Tests.dll
  AppHost.Bundle.Tests -> /runtime/artifacts/bin/AppHost.Bundle.Tests/Release/net6.0/AppHost.Bundle.Tests.dll
  Microsoft.NET.HostModel.Bundle.Tests -> /runtime/artifacts/bin/Microsoft.NET.HostModel.Bundle.Tests/Release/net6.0/Microsoft.NET.HostModel.Bundle.Tests.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:01:15.85

@safern safern requested a review from dagood November 21, 2020 00:15
safern
safern approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a question, LGTM

@safern
Copy link
Member

safern commented Nov 21, 2020

Thanks for fixing this. I'll look at the result on those builds on CI and merge if everything makes sense.

@am11
Copy link
Member Author

am11 commented Nov 21, 2020

Is it possible to trigger the official build pipeline (or something close), while PR is still opened? If so, please trigger them too. :)

@safern
Copy link
Member

safern commented Nov 21, 2020

Is it possible to trigger the official build pipeline (or something close), while PR is still opened? If so, please trigger them too. :)

Yeah, doing that. I need to mirror your branch 😄

@dagood dagood requested review from NikolaMilosavljevic and removed request for dagood November 21, 2020 00:44
@safern
Copy link
Member

safern commented Nov 21, 2020

I've queued the official build, will let you know the results.

@safern
Copy link
Member

safern commented Nov 21, 2020

It seems like the official build will be green:

 Microsoft.NETCore.DotNetHostPolicy -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostPolicy.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHostResolver.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHost -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHost -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHostResolver -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostResolver.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetHostPolicy -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetAppHost -> /root/runtime/artifacts/packages/Release/Shipping/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetAppHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.DotNetAppHost -> /root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.DotNetAppHost.6.0.0-alpha.1.20570.13.nupkg
  Microsoft.NETCore.App.Ref -> 
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-alpha.1.20570.13.nupkg'.
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Ref.6.0.0-alpha.1.20570.13.symbols.nupkg'.
  Microsoft.NETCore.App.Runtime -> 
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-alpha.1.20570.13.nupkg'.
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.linux-musl-arm64.6.0.0-alpha.1.20570.13.symbols.nupkg'.
  Microsoft.NETCore.App.Host -> 
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-alpha.1.20570.13.nupkg'.
  Successfully created package '/root/runtime/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Host.linux-musl-arm64.6.0.0-alpha.1.20570.13.symbols.nupkg'.

FYI for whoever didn't see the issue, discussion on the fix is here: #45027 (comment)

@safern
Copy link
Member

safern commented Nov 21, 2020

Official build is green and with expected outputs. Merging

@safern safern merged commit 6c80a3d into dotnet:master Nov 21, 2020
@safern safern mentioned this pull request Nov 21, 2020
Closed
@am11 am11 deleted the feature/consolidation/msbuild-properties branch November 25, 2020 02:53
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

@NikolaMilosavljevic NikolaMilosavljevic Awaiting requested review from NikolaMilosavljevic

Assignees
No one assigned
Labels
area-Setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @safern @Dotnet-GitSync-Bot