-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share unix getexepath() definition via src/native #44999
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@jkotas, now that coreconsole is deleted, the only consumer of unixcoreruncommon static lib is unixcorerun. I was thinking about merging these two projects in a separate PR, but since we need the definition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! I really appreciate all the improvements that you are making in the .NET!
Hello @janvorli! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
The failures are unrelated, but the libraries tests were timing out, so we don't know their outcome. I think the cause for that timeout was fixed, so let me try to re-run the runtime tests one more time. I'll merge the change if the timeout issue is still there. |
Thanks. |
Thank you for the reviews, @janvorli. Much appreciate your thoughts with many learning points everytime! 👍 |
Deduplicate implementations via a new shared location;
src/native/common
.cc @janvorli, @jkotas