Fix handling of \G in Regex.Split/Replace #44975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our optimized Regex.Split loop, we failed to update runtextstart, which means the \G anchor (aka starting where the previous match ended).
|
Tagging subscribers to this area: @eerhardt, @pgovind, @jeffhandley Issue DetailsIn our optimized Regex.Split/Replace loop, we failed to update runtextstart, which means the \G anchor (aka starting where the previous match ended) would fail to match after the first one because it would be attempting to match at the initial start rather than where the last match left off. One-line fix to up the field correctly, and then some tests. Fixes #44957
|
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/373715607 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our optimized Regex.Split/Replace loop, we failed to update runtextstart, which means the \G anchor (aka starting where the previous match ended) would fail to match after the first one because it would be attempting to match at the initial start rather than where the last match left off.
One-line fix to up the field correctly, and then some tests.
Fixes #44957