Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more LINQ usage from various dotnet/runtime libraries #44964

Merged
merged 16 commits into from
Nov 20, 2020
Merged

Remove more LINQ usage from various dotnet/runtime libraries #44964

merged 16 commits into from
Nov 20, 2020

Conversation

stephentoub
Copy link
Member

No description provided.

@stephentoub
Remove unnecessary OrderBy / copy from MemoryCache.Compact
4e95852
@stephentoub
Replace First() in ILEmitResolverBuilder with [0]
9245fc7
@stephentoub
Remove stale "using System.Linq;" from System.Text.Json
f81e0e2
@stephentoub
Remove stale "using System.Linq;" from System.Security.Cryptography.X…
1ffe39a 
…509Certificates
@stephentoub
Remove some LINQ usage from System.Security.Cryptography.Pkcs
873ab79
@stephentoub
Remove System.Linq reference from System.Private.Xml
8f6d470
@stephentoub
Remove System.Linq reference from System.Net.WebHeaderCollection
42be6be
@stephentoub
Remove stale "using System.Linq;" from CookieContainer
dab0e0c
@stephentoub
Remove stale "using System.Linq;" from AltSvcHeaderParser
087ab44
@stephentoub
Remove Enumerable.Contains on a string from System.IO.Packaging
bdd75f8
@stephentoub
Remove System.Linq dependency from System.Diagnostics.Process
99dc4a0
@stephentoub
Remove LINQ usage from Microsoft.Extensions.Options
da7bcdd
@stephentoub
Remove LINQ usage from Microsoft.Extensions.Logging
3008054
@stephentoub
Remove LINQ usage from Microsoft.Extensions.Logging.Console
cb81ded
@stephentoub
Remove LINQ from CollectionExtensions.GetAssets/RuntimeFiles
3d81cb8
@stephentoub @bartonjs
Update src/libraries/System.Security.Cryptography.Pkcs/src/System/Sec…
9be95c0 
…urity/Cryptography/Pkcs/Rfc3161TimestampToken.cs

Co-authored-by: Jeremy Barton <[email protected]>
maryamariyan
maryamariyan approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@maryamariyan maryamariyan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensions diff LGTM with a question.

src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLoggerProvider.cs Show resolved Hide resolved
src/libraries/Microsoft.Extensions.DependencyModel/src/CollectionExtensions.cs Show resolved Hide resolved
adamsitnik
adamsitnik approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The System.Diagnostics.Process part LGTM

src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs Show resolved Hide resolved
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Linux.cs Show resolved Hide resolved
@eerhardt
Copy link
Member

using System.Linq;

(nit) Can the using be removed now?

Refers to: src/libraries/Microsoft.Extensions.DependencyModel/src/CollectionExtensions.cs:5 in 9be95c0. [](commit_id = 9be95c0, deletion_comment = False)

eerhardt
eerhardt reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft.Extensions changes LGTM

@stephentoub stephentoub merged commit f9a8abc into dotnet:master Nov 20, 2020
@stephentoub stephentoub deleted the removemorelinq branch November 20, 2020 23:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtqqczze xtqqczze xtqqczze left review comments

@am11 am11 am11 left review comments

@bartonjs bartonjs bartonjs approved these changes

@eerhardt eerhardt eerhardt approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@maryamariyan maryamariyan maryamariyan approved these changes

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@jozkee jozkee Awaiting requested review from jozkee

@layomia layomia Awaiting requested review from layomia

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stephentoub @eerhardt @am11 @maryamariyan @adamsitnik @bartonjs @xtqqczze @Dotnet-GitSync-Bot