Enables the interpreter on iOS #44911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveisok
requested review from
akoeplinger,
EgorBo,
marek-safar and
vargaz
as code owners
added 2 commits
November 19, 2020 09:11
To enable on tests, you can pass MonoForceInterpreter=true as an extra MSBuild property. AppleAppBuilder will also have a ForceInterpreter property on it in order to flow down to device / simulator. Additionally, removed eventpipe from iOS when TargetsiOSSimulator == true as it was asserting for debug builds.
…enable the debug configuration to work for the time being
steveisok
force-pushed
the
ios-interp
branch
from
65ea879 to
e093995
Compare
EgorBo
approved these changes
Nov 19, 2020
lateralusX
reviewed
Nov 19, 2020
|
Looks like that triggered a build error on older IOS SDK versions. Then we should just enable the simulator for now and I can look/fix that in separate PR and enable the rest of IOS platforms. |
akoeplinger
approved these changes
Nov 19, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable on tests, you can pass MonoForceInterpreter=true as an extra MSBuild property.
AppleAppBuilder will also have a
ForceInterpreterproperty on it in order to flow down to device / simulator.