[mono] Unconditionally check llvm::Expected<T> for success #44908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`assert()` will expand to a no-op if NDEBUG isn't defined, which can cause an assertion-enabled LLVM to trap if an `llvm::Expected<T>` is destroyed before having had `operator bool` applied to it.
|
Tagging subscribers to this area: Issue Details
|
vargaz
approved these changes
Nov 19, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert()will expand to a no-op if NDEBUG is defined, which cancause an assertion-enabled LLVM to trap if an
llvm::Expected<T>isdestroyed before having had
operator boolapplied to it.