Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special-case zero parameter array allocations in GetParameters #44759

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Nov 16, 2020

In an empty MVC app created with dotnet new mvc, this drops ParameterInfo[] allocations by 12% (from 758 to 667).

Related to #44598

@stephentoub stephentoub added this to the 6.0.0 milestone Nov 16, 2020
@jkotas
Copy link
Member

jkotas commented Nov 17, 2020

Failure is #11063

@jkotas jkotas merged commit 76db6cd into dotnet:master Nov 17, 2020
@stephentoub stephentoub deleted the zeroparameters branch November 21, 2020 01:10
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants