Fix ListSeparator with ICU #44732
Fix ListSeparator with ICU #44732
Conversation
|
Tagging subscribers to this area: @tarekgh, @safern, @krwq Issue Details
|
src/libraries/System.Globalization/tests/System/Globalization/TextInfoTests.cs
Show resolved
Hide resolved
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/368791361 |
| int separator = IcuLocaleData.GetLocaleDataNumericPart(cultureName, IcuLocaleDataParts.DigitSubstitutionOrListSeparator); | ||
| if (separator != -1) | ||
| { | ||
| switch (separator & 0xFFFF0000) |
There was a problem hiding this comment.
Should this mask be in a named const in IcuLocaleData.cs, since it's strongly related to the values of the various XxSep named consts there?
There was a problem hiding this comment.
I already have this PR ported to the 5.0 release. How important to apply this comment there? I can add it to master though.
There was a problem hiding this comment.
master is fine. I didn't get a chance to review that PR before it was merged.
There was a problem hiding this comment.
The servicing PR is not merged yet. It is here #44823 just in case.
There was a problem hiding this comment.
Ok, I'll do that then. Thanks!
There was a problem hiding this comment.
This is done and the delta change also included in the 5.0 PR too as @safern thankfully pointed.
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/370964110 |
ghost
locked as resolved and limited conversation to collaborators
#43795
When using ICU, we used to return the
TextInfo.ListSeparatorvalue as the decimal separator which is incorrect. The fix here is return the same values of ListSeparator which is returned by NLS. This fix will avoid the breaks when using such separator when parsing Excel CSV files containing a list of multi values data.