Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arm64 disasm failures #44547

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Fix arm64 disasm failures #44547

merged 1 commit into from
Nov 12, 2020

Conversation

BruceForstall
Copy link
Member

GTF_ICON_STATIC_HDL and GTF_ICON_FTN_ADDR can't be converted
to names using eeGetFieldName and eeGetMethodFullName, respectively.
So, just print out the type of the target.

Fixes #40354

@BruceForstall
Fix arm64 disasm failures
d45bb7b 
GTF_ICON_STATIC_HDL and GTF_ICON_FTN_ADDR can't be converted
to names using eeGetFieldName and eeGetMethodFullName, respectively.
So, just print out the type of the target.

Fixes dotnet#40354
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 11, 2020
@BruceForstall
Copy link
Member Author

@kunalspathak PTAL
cc @dotnet/jit-contrib

kunalspathak
kunalspathak approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@BruceForstall BruceForstall merged commit b2e5a89 into dotnet:master Nov 12, 2020
@BruceForstall BruceForstall deleted the FixAltjitDump branch November 12, 2020 00:36
briansull
briansull reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@briansull briansull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briansull briansull briansull left review comments

@kunalspathak kunalspathak kunalspathak approved these changes

@echesakov echesakov echesakov approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Arm64] Crossgen fails to compile some methods with NGenDump enabled
5 participants
@BruceForstall @echesakov @briansull @kunalspathak @Dotnet-GitSync-Bot