Add ICorDebugHeapValue4 -- CreatePinnedHandle #44471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chuckries
approved these changes
Nov 10, 2020
sdmaclea
force-pushed
the
createPinnedHandle
branch
from
b33db21 to
a122ca3
Compare
|
Thanks @sdmaclea! LGTM, though I'm not too familiar with adding APIs in this area. |
hoyosjs
approved these changes
Nov 10, 2020
|
Tagging subscribers to this area: @tommcdon Issue meta data
|
|
@kouvel I expect when you have the rest of the tiered JIT, data breakpoint deadlock fix finished. You will backport the whole fix to 5.0 servicing branch. |
|
Yep about to put up a PR for my side shortly, will port both once that's in |
kouvel
added a commit
to kouvel/runtime
that referenced
this pull request
Nov 11, 2020
…ding in some cases 1. When suspending for the debugger is in progress (the debugger is waiting for some threads to reach a safe point for suspension), a thread that is not yet suspended may trigger another runtime suspension. This is currently not allowed because the order of operations conflicts with requirements to send GC events for managed data breakpoints to work correctly when suspending for a GC. Instead, the thread suspends for the debugger first, and after the runtime is resumed, continues suspending for GC. 2. At the same time, if the thread that is not suspended yet is in a forbid-suspend-for-debugger region, it cannot suspend for the debugger, which conflicts with the above scenario, but is currently necessary for the issue fixed by dotnet#40060 3. The current plan is to change managed data breakpoints implementation to pin objects instead of using GC events to track object relocation, and to deprecate the GC events APIs 4. With that, the requirement in #1 goes away, so this change conditions the check to avoid suspending the runtime during a pending suspension for the debugger when GC events are not enabled - Verified that the latest deadlock seen in dotnet#42375 manifests only when a data breakpoint set and not otherwise - Combined with dotnet#44471 and a VS update to use that to switch to the pinning mechanism, the deadlock issue seen above should disappear completely
sdmaclea
added a commit
to sdmaclea/runtime
that referenced
this pull request
Nov 11, 2020
* Add ICorDebugHeapValue4 * Add EnableGCNotificationEvents deprecation comment
sdmaclea
added a commit
that referenced
this pull request
Nov 24, 2020
#44563) * Add ICorDebugHeapValue4 -- CreatePinnedHandle (#44471) * Add ICorDebugHeapValue4 * Add EnableGCNotificationEvents deprecation comment * Drop support for IID_ICorDebugProcess10 and fix thread suspend logic (#44549) * Stop providing IID_ICorDebugProcess10 Prevent older VS versions from setting managed data breakpoints. * Simplify the thread collision logic to prevent deadlock This is a simplification of #44539 as proposed by @kouvel
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.