add support for less standard serial port speeds on macOS #44052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @krwq |
This was referenced Oct 30, 2020
|
codewise LGTM, we will need someone with the right hardware to test this, @MicBoucinha any chance you could try this out? (easiest way is to sync with @wfurt's branch, build the repo and test this code inside of tests directory which will use the right binaries automatically) |
|
I was planning to write instructions how to grab bits from this PR. (I just did not get to it over the weekend) |
|
(and I plan to keep it as draft until we get verification) |
|
@krwq I tested it and it works on my machine. I followed the instructions left by wfurt on the issue #43719 (comment) |
|
Thanks @MicBoucinha for confirmation. |
|
can you please take final look @krwq? It seems like this works as expected. |
|
ping @krwq? |
krwq
approved these changes
Nov 24, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like macOS terms end with B230400 (probably limit of legacy serial) but many USB serial devices can do more.
When .NET tries to use higher speed it always fails as we fail to lookup platform speed mapping. macOS has call to set specific speed so this PR use that as fallback if speed lookup fails. That leaves the decision to driver and OS e.g. it will either succeed or fail and we report that accordingly.
I don't have enough gear to but I was able to verify that serial port can be opened with speed beyond B230400.
fixes #43719