[wasm][debugger][tests] Make dotnet test DebuggerTestSuite.csproj work
#43158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the tests can be run with `dotnet test DebuggerTestSuite.csproj`. and the existing `make run-debugger-tests` still works. Changes: - We don't need to use wasmAppBuilder for all the test projects, only `debugger-test`. - Other assemblies just get bundled with `debugger-test` - Move common properties to `Directory.Build.*` - And move the settings being used for debugger-test in the Makefile to msbuild: - RuntimeConfiguration defaults to Release, same as what the Makefile did - build all the debugger-tests in artifacts dir - And instead of `TEST_SUITE_PATH`, determine the debugger-tests path based on the testsuite itself. - We can then remove `build-debugger-test-app`
|
Tagging subscribers to this area: @thaystg |
radical
changed the title
dotnet test DebuggerTestSuite.csproj work
This was referenced Oct 8, 2020
lewing
approved these changes
Oct 9, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the tests can be run with
dotnet test DebuggerTestSuite.csproj.and the existing
make run-debugger-testsstill works.Changes:
We don't need to use wasmAppBuilder for all the test projects, only
debugger-test.debugger-testMove common properties to
Directory.Build.*And move the settings being used for debugger-test in the Makefile to
msbuild:
Makefile did
build all the debugger-tests in artifacts dir
And instead of
TEST_SUITE_PATH, determine the debugger-tests pathbased on the testsuite itself.
We can then remove
build-debugger-test-app