fix async logic in MultipleConnectAsync to avoid lock reentrancy issues #42919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
approved these changes
Oct 2, 2020
| public bool StartConnectAsync(SocketAsyncEventArgs args, DnsEndPoint endPoint) | ||
| { | ||
| IAsyncResult result; |
There was a problem hiding this comment.
Unrelated to your pr, it'd be nice for the next release to remove all of the APM usage from these code paths.
src/libraries/System.Net.Sockets/src/System/Net/Sockets/MultipleConnectAsync.cs
Outdated
Show resolved
Hide resolved
…leConnectAsync.cs Co-authored-by: Stephen Toub <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42198 (hopefully)
When sync completions occur in this logic, we are sometimes invoking the callback directly while holding the lock, which leads to lock reentrancy and all sorts of badness.
Fix the logic to avoid this.
Also add asserts to ensure we are never inadvertently reentering the lock.