[release/5.0-rc2] Implement SocketsHttpHandler.ConnectCallback #42075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 10 commits
September 10, 2020 16:18
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Dotnet-GitSync-Bot
added
area-CodeGen-coreclr
karelz
added
area-System.Net.Http
and removed
area-CodeGen-coreclr
|
Tagging subscribers to this area: @dotnet/ncl |
scalablecory
approved these changes
Sep 10, 2020
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41955 to release/5.0-rc2
Fixes #41949
/cc @geoffkizer
Customer Impact
We removed System.Net.Connections from 5.0. This resulted in also removing the ConnectionFactory property on SocketsHttpHandler, which allowed you to provide your own connection that SocketsHttpHandler would use instead of simply doing a standard TCP connection to the specified server.
We have heard from several customers, particularly Bing and gRPC, that the loss of this functionality impacts scenarios they want to enable on top of 5.0. In particular, Bing said that this functionality is "the #1 feature in .NET 5 that will solve actual business problems for us”.
The ConnectCallback property is a replacement for ConnectionFactory that provides similar capabilities without relying on the System.Net.Connections code.
In particular, it allows you to provide your own transport (e.g. Unix domain sockets, or in-memory pipes, etc), or augment a standard TCP connection with your own logic (e.g. bandwidth monitoring, wrapping with your own prefix etc), or configure a standard TCP connection (e.g. bind to a specific local IP address, or enable TCP keepalive, etc).
Testing
We have validated with Bing and gRPC that the ConnectCallback property provides the functionality they need to enable their scenarios.
We've added tests that validate the feature, including modifying the old ConnectionFactory tests to use ConnectCallback as well as additional tests.
Risk
The risk here is relatively low. We have some experience with providing this hook from the previous ConnectionFactory property. The new property is implemented in a similar way, just using a delegate instead of the Connections infrastructure.