Revert #40641 #41817
Merged
Revert #40641 #41817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts "Ensure FileStatus and FileSystemEntry Hidden and ReadOnly attributes are retrieved the same way" (commit 6ed1e41) which introduced a perf regression.
carlossanlop
requested review from
jeffhandley,
stephentoub,
danmoseley and
jozkee
|
/backport to release/5.0-rc2 |
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/238165020 |
jeffhandley
approved these changes
Sep 3, 2020
|
Is this revert in master necessary? Can we work on addressing the perf regression on top of this, without having to remove the commit? |
|
I have a slight preference to make the revert and get to a good baseline before attempting the fix again, but I defer to you and @adamsitnik for your recommendation. |
|
Ok no problem @jeffhandley. I can get it in a new PR, with the fix. |
|
Sounds good, @carlossanlop; thanks. And there's no urgency on it now--we can just reopen the original issue into the 6.0.0 milestone and have it in the backlog. |
sounds good to me 👍 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41739
Reverts PR #40641 - "Ensure FileStatus and FileSystemEntry Hidden and ReadOnly attributes are retrieved the same way" which introduced a perf regression on Unix in
Directory.EnumerateFiles.