-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add granular suppressions for linker warnings #40691
Conversation
Tagging subscribers to this area: @safern, @ViktorHofer |
d521aff
to
5f94aeb
Compare
In the past we put the rd.xml files into the Properties ( |
There are a set of ILLink related files that traditionally have been in the root of the project. Mono started grouping them into a folder specifically for this area, and it has worked out well as we've been adding more files in this space. We are already putting ILLink related files in In the worst case, we have almost 10 ILLinker files for one library - https://github.com/dotnet/runtime/tree/master/src/libraries/System.Private.CoreLib/src/ILLink |
...es/System.Private.Runtime.InteropServices.JavaScript/src/ILLink/ILLink.Suppressions.wasm.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the CI is green, this LGTM. Thanks for pulling this off - great work.
Right I agree that we shouldn't have them in the project root. I was asking if it would make more sense to put them into the |
The only existing places I see using a This PR is just following the established pattern and making the repo consistent. If you feel strongly the existing pattern should be changed, can you log an issue for it? |
Changes dotnet#40691 and dotnet#42824 conflicted. One added a new ILLink suppress warnings file, while the other added more warnings. This causes the build to break. The fix is to regenerate the suppressions file with the latest code. Fix dotnet#42926
Addresses #38033.
cc @mateoatr