Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused locals in System.ServiceProcess.ServiceController #39640

Conversation

MattKotsenas
Copy link
Member

Remove unused locals and private methods in System.ServiceProcess.ServiceController.

This fixes a part of #30457.

@MattKotsenas
Copy link
Member Author

@danmosemsft, sorry for the bother, but would you be able to recommend a reviewer for this change? I looked at git history but there isn't a long trail of changes to follow. Alternatively; if there's a doc or tool to use to find owners, please let me know. Thanks!

Remove unused locals and private methods in
System.ServiceProcess.ServiceController.

This fixes a part of dotnet#30457.
@MattKotsenas
Copy link
Member Author

Tagging @Anipik per https://github.com/dotnet/runtime/blob/master/docs/area-owners.md. @Anipik, would you mind taking a look, or suggesting a reviewer when you get a chance? Thanks!

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, looks good to me. Thanks!

@danmoseley
Copy link
Member

Unrelated failures

Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MattKotsenas MattKotsenas deleted the refactor/30457-System.ServiceProcess.ServiceController branch August 11, 2020 15:41
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants