WASM: Fix System.Diagnostics.Tracing #39271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was missing a few signatures in wasm_m2n_invoke.g.h that caused it to fail with `WASM-ERR: CANNOT HANDLE INTERP ICALL SIG IIILIIII`
akoeplinger
requested review from
alexischr,
CoffeeFlux,
lambdageek and
SamMonoRT
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Its missing the changes to the generator .cs. |
|
the generator still lives in mono/mono. will open a PR to update the generator there. |
|
If you want to port it to dotnet/runtime here's the diff: |
stephentoub
reviewed
Jul 14, 2020
| @@ -296,6 +296,16 @@ wasm_invoke_iiliiii (void *target_func, InterpMethodArguments *margs) | |||
|
|
|||
| } | |||
|
|
|||
| static void | |||
| wasm_invoke_iiiliiii (void *target_func, InterpMethodArguments *margs) | |||
There was a problem hiding this comment.
Oh, it's the signature, i.e. it returns an int, and accepts two ints, then a long, then four ints?
vargaz
approved these changes
Jul 14, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was missing a few signatures in wasm_m2n_invoke.g.h that caused it to fail with
WASM-ERR: CANNOT HANDLE INTERP ICALL SIG IIILIIII