Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM enable System.Collections.Specialized.Tests #39012

Merged
merged 1 commit into from
Jul 10, 2020
Merged

WASM enable System.Collections.Specialized.Tests #39012

merged 1 commit into from
Jul 10, 2020

Conversation

safern
Copy link
Member

@safern safern commented Jul 9, 2020

Tests are passing after: #38948

Contributes towards: #38422

cc: @steveisok @akoeplinger

@ghost
Copy link

ghost commented Jul 9, 2020

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

@steveisok steveisok mentioned this pull request Jul 9, 2020
Closed
99 tasks
@safern safern force-pushed the wasm-systemcollectionsspecializedtests branch from 868b463 to 168b6e7 Compare July 9, 2020 19:58
@safern
Copy link
Member Author

safern commented Jul 9, 2020 •
edited
Loading

cc: @GrabYourPitchforks these tests might be using BinaryFormatter in some codepaths that we might need to disable as part of your change to disable BinaryFormatter in wasm.

I'll mark this as NO-MERGE in order to do all as part of this PR once your PR is merged.

@safern safern added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 9, 2020
@akoeplinger
Copy link
Member

@safern shouldn't we get this enabled without blocking on the BinaryFormatter PR? I'd imagine we can just fix any issues there.

@safern
Copy link
Member Author

safern commented Jul 9, 2020

@safern shouldn't we get this enabled without blocking on the BinaryFormatter PR? I'd imagine we can just fix any issues there.

Yeah, based on the offline conversation we had, it is fine to merge.

@safern safern removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 9, 2020
@safern safern merged commit 838fcff into dotnet:master Jul 10, 2020
@safern safern deleted the wasm-systemcollectionsspecializedtests branch July 10, 2020 00:27
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
area-System.Collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safern @akoeplinger @Dotnet-GitSync-Bot