Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing Windows arm32 tests #38844

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Disable failing Windows arm32 tests #38844

merged 1 commit into from
Jul 7, 2020

Conversation

BruceForstall
Copy link
Member

Issue: #36199

@BruceForstall BruceForstall added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Infrastructure-coreclr labels Jul 7, 2020
kunalspathak
kunalspathak reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see these test failing without JitStress flags. Are they being disable so they don't get run in JitStress mode?

@BruceForstall
Copy link
Member Author

Are they being disable so they don't get run in JitStress mode?

Yes. We don't have the ability (that I know of) to disable for a particular OS + architecture + stress mode combination, so disabling just for OS + architecture seems like a better option than disabling for JitStress.

@BruceForstall
Copy link
Member Author

Windows x86 'pauseonstart' failure is known: #38847

@BruceForstall BruceForstall merged commit 311fd81 into dotnet:master Jul 7, 2020
@BruceForstall BruceForstall deleted the DisableMccTests branch July 7, 2020 15:01
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Jul 7, 2020
@kunalspathak
Revert "Disable failing Windows arm32 tests (dotnet#38844)"
db7e86d 
This reverts commit 311fd81.
kunalspathak added a commit that referenced this pull request Jul 8, 2020
@kunalspathak
Use the latest base register while accessing the stack (#38834)
8988325 
* logging

* the fix

* revert lclvars.cpp changes

* Revert "revert lclvars.cpp changes"

This reverts commit d39af7084687e8fe5e6d4f71674ec84d36a88340.

* wip

* revert lclvars.cpp changes

* deleted inst_RV_ST()

* removing logging, added some asserts

* jit-formatting

* add back case of INS_add and some more asserts

* reset lclvars.cpp

* delete comments and cleanup code

* revert changes inside common.il

* Revert "Disable failing Windows arm32 tests (#38844)"

This reverts commit 311fd81.

* review comments

* added standard function header
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BruceForstall @stephentoub @kunalspathak @Dotnet-GitSync-Bot