-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new Microsoft.DotNet.SharedFramework.Sdk and refactor Host/Installer build subsets #38457
Conversation
…K in the NewSFX subset.
…nuget packaging projects.
…-unified-sharedfx
… from the runtime.
Marking no merge again until this PR can consume a Microsoft.DotNet.Build.Tasks.Installers with dotnet/arcade#6549 |
Once we have that, we can merge this PR. |
@jkoritzinsky just fyi, the PBsign changes got merges |
I saw. I'm integrating them now locally and validating. I'm going to remove the non PBsign path in Signing.props since it doesn't work any more (we'll still sign the DAC and DBI). |
Fix for the wrong msbuild function name: dotnet/arcade#6552 |
c4f6713
to
e36639b
Compare
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Congrats 🎉 |
<ItemsToSignWithPaths Include="$(DownloadDirectory)**/*.zip" Condition="'$(PrepareArtifacts)' == 'true'" /> | ||
|
||
<ItemsToSignWithoutPaths Include="@(ItemsToSignWithPaths->'%(Filename)%(Extension)')" /> | ||
<ItemsToSignPostBuild Include="@(ItemsToSignWithoutPaths->Distinct())" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkoritzinsky This PR removed this line, which will break post build signing. Post build signing breaks signing into two categories:
ItemsToSign and ItemsToSignPostBuild. ItemsToSign corresponds to those items that should always be signed during the build (when PostBuildSign is true or false), and ItemsToSignPostBuild should contain items to sign in post build, only if PostBuildSign = true.
The use of target should be unnecessary.
/cc @ViktorHofer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you will only need the setup for ItemGroupsWhen PostBuildSign=true. This does not need to be done in a target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot. I’ll put out a PR to add back this item group.
Use the new Microsoft.DotNet.SharedFramework.Sdk to build the Microsoft.NETCore.App shared framework, targeting pack, apphost pack, dotnet-host installer, dotnet-hostfxr installer, runtime-deps installers, and the bundle installers.
This PR also replaces the subsets in the installer space with the following subsets:
Fixes #3730
Fixes #1616
Fixes #1622
Fixes #44320