Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vector2/4 Lerp methods #37764

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Fix Vector2/4 Lerp methods #37764

merged 2 commits into from
Jun 13, 2020

Conversation

john-h-k
Copy link
Contributor

@john-h-k john-h-k commented Jun 11, 2020 •
edited
Loading

  • Added 2 new tests, which failed on the old lerp methods
  • Added +/-inf tests to Vector3/4 for consistency with Vector2 (where +/-inf tests were already present)

Fixes #35529

@ghost
Copy link

ghost commented Jun 11, 2020

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

@john-h-k
Copy link
Contributor Author

I see there are 3 unrelated commits but I do not know how to get rid of them, and they were merged in a different PR and produce no diff

@tannergooding
Copy link
Member

I see there are 3 unrelated commits but I do not know how to get rid of them, and they were merged in a different PR and produce no diff

Helped John over in Discord, it's down to the 2 commits now 😄

@tannergooding
Copy link
Member

CC. @pgovind

@tannergooding tannergooding mentioned this pull request Jun 13, 2020
Closed
@tannergooding
Copy link
Member

Breaking change doc was logged here: dotnet/docs#18937

@tannergooding tannergooding merged commit ba4dc36 into dotnet:master Jun 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Numerics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector2/4.Lerp do not always return value2 when amount is 1
3 participants
@john-h-k @tannergooding @Dotnet-GitSync-Bot