RyuJIT: Don't convert GT/LE to EQ/NE for "ARR_LEN cmp 0" #35758
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RyuJIT converts
(uint)x > 0
tox != 0
(same for<=
) but I suggest we keep it as it is for things like(uint)array.Length > 0
since!=
and==
operators are not bound checks elimination friendly, e.g.:Before my changes
^ As you can see, bound checks are removed only for "unnatural" (IMO) condition in
Foo3
That's why we have this "unnatural" conditions in String.IsNullOrEmpty and other places.
After my changes