skip Microsoft.XmlSerializer.Generator.Tests on FreeBSD #35494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Apr 27, 2020
stephentoub
approved these changes
Apr 27, 2020
am11
reviewed
Apr 27, 2020
| @@ -3,7 +3,7 @@ | |||
| <DefineConstants>$(DefineConstants);XMLSERIALIZERGENERATORTESTS</DefineConstants> | |||
| <TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks> | |||
| <CoverageSupported>false</CoverageSupported> | |||
| <SkipTestsOnPlatform Condition="'$(TargetOS)' == 'iOS' or '$(TargetOS)' == 'tvOS' or '$(TargetArchitecture)' == 'arm' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'armel' or '$(TargetArchitecture)' == 'wasm'">true</SkipTestsOnPlatform> | |||
| <SkipTestsOnPlatform Condition="'$(TargetOS)' == 'FreeBSD' or '$(TargetOS)' == 'iOS' or '$(TargetOS)' == 'tvOS' or '$(TargetArchitecture)' == 'arm' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'armel' or '$(TargetArchitecture)' == 'wasm'">true</SkipTestsOnPlatform> | |||
There was a problem hiding this comment.
It was failing in cross build, since this test tries to invoke artifacts/bin/testhost/netcoreapp5.0-FreeBSD-Release-x64/dotnet executable, which is target-compatible on host during the build.
I think we change this condition to check if cross build is true, so it still builds on the device/OS? This will also hold for Android on-device build.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaks build.sh -subset libs.tests -os FreeBSD
Executing test dotnet will not work for cross-targets.
We may gave better way how to track this but for now I'm just adding another TargetOS here.
cc: @am11