Single-File: Pass BUNDLE_PROBE property to the runtime #34845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @swaroop-sridhar as an area owner. If you would like to be tagged for a label, please notify danmosemsft. |
swaroop-sridhar
force-pushed
the
property
branch
6 times, most recently
from
f4c4315 to
a710057
Compare
vitek-karas
approved these changes
Apr 14, 2020
vitek-karas
approved these changes
Apr 15, 2020
As described in the [design doc](https://github.com/dotnet/designs/blob/master/accepted/2020/single-file/design.md#startup), pass the bundle_probe function pointer encoded as a string to the runtime.
swaroop-sridhar
force-pushed
the
property
branch
from
7d70de7 to
8f5a976
Compare
Type the path-string as a char16_t* string instead of wchar_t* wchar_t* size varies by architecture. bool STDMETHODCALLTYPE bundle_probe(const char16_t* path, int64_t* offset, int64_t* size);
swaroop-sridhar
force-pushed
the
property
branch
from
8f5a976 to
adb4e63
Compare
|
@vitek-karas I updated the to because:
Therefore, the interface uses the fixed char16_t type. This fixed the test failures on Linux. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the design doc, pass the bundle_probe function pointer encoded as a string to the runtime.