Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SequenceReader.TryPeek(long offset, out T value) #346

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Implement SequenceReader.TryPeek(long offset, out T value) #346

merged 3 commits into from
Dec 5, 2019

Conversation

MarcoRossignoli
Copy link
Member

@danmoseley danmoseley requested a review from ahsonkhan November 28, 2019 00:53
@ahsonkhan ahsonkhan added this to the 5.0 milestone Dec 3, 2019
ahsonkhan
ahsonkhan approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, looks good.

@ahsonkhan
Copy link
Contributor

The System.Net.Mail.Tests.SmtpClientTest failure is unrelated. https://github.com/dotnet/corefx/issues/37775

@ahsonkhan ahsonkhan mentioned this pull request Dec 4, 2019
Closed
@ahsonkhan
Copy link
Contributor

The System.IO.Tests.FileSystemWatcherTests failure is unrelated. #504

@MarcoRossignoli
Copy link
Member Author

@ahsonkhan can we merge this?

@ahsonkhan ahsonkhan merged commit 3b8f1c9 into dotnet:master Dec 5, 2019
@ahsonkhan
Copy link
Contributor

can we merge this?

Done, thanks.

@MarcoRossignoli MarcoRossignoli deleted the sequencereader branch December 5, 2019 21:52
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

Assignees
No one assigned
Labels
area-System.Buffers
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcoRossignoli @ahsonkhan @maryamariyan @Dotnet-GitSync-Bot