add FreeBSD build #34521
Merged
add FreeBSD build #34521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
reviewed
Apr 3, 2020
safern
reviewed
Apr 3, 2020
added 2 commits
April 3, 2020 16:57
safern
reviewed
Apr 4, 2020
safern
reviewed
Apr 4, 2020
safern
reviewed
Apr 6, 2020
safern
reviewed
Apr 6, 2020
safern
reviewed
Apr 6, 2020
safern
reviewed
Apr 11, 2020
safern
reviewed
Apr 11, 2020
|
Failing checked builds seems to be know issue: #34881 |
19 tasks
safern
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
LGTM.
Could you please also cleanup this? https://github.com/dotnet/runtime/blob/master/eng/pipelines/common/xplat-setup.yml#L100-L102
|
done. |
jkotas
approved these changes
Apr 18, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds FreeBSD build to avoid build regressions. Unlike previous attempt to build on FreeBSD, this will use container on Linux with FreeBSD rootfs. This will allow us to avoid issues with getting stability of build agent as well as dependency on Azure support.
There is currently no test infrastructure to verify all tests passing.