Code

[WIP] Test PR#34344

Code

Closed

fadimounir wants to merge 13 commits intodotnet:masterdotnet/runtime:masterfrom fadimounir:covarient_returnfadimounir/runtime:covarient_returnCopy head branch name to clipboard

+6,984-54

Commits

Commits on Apr 9, 2020

• Initial implementation: allowing covariant return types on MethodImpl overrides on classes

  Show description for c1c9cdc
  

  Fadi Hanna

  committed
  c1c9cdc

  Copy full SHA for c1c9cdc

• Correct handling for generic base types and their substitutions

  Show description for a4bc6de
  

  Fadi Hanna

  committed
  a4bc6de

  Copy full SHA for a4bc6de

• Handling of struct and interface return types

  

  Fadi Hanna

  committed
  5bc0af4

  Copy full SHA for 5bc0af4

• Some fixes and refactoring of code

  

  Fadi Hanna

  committed
  55e9ae8

  Copy full SHA for 55e9ae8

• Add some unit tests

  

  Fadi Hanna

  committed
  df8219e

  Copy full SHA for df8219e

• Remove some debug code and fix some comments text

  

  Fadi Hanna

  committed
  6e59218

  Copy full SHA for 6e59218

• Add unit test using delegates

  

  Fadi Hanna

  committed
  8720cec

  Copy full SHA for 8720cec

Commits on Apr 10, 2020

• Add design doc

  

  Fadi Hanna

  committed
  2edbc7f

  Copy full SHA for 2edbc7f

• Fix formatting issue

  

  Fadi Hanna

  committed
  135f495

  Copy full SHA for 135f495

• Add more unit tests and fix #ifdef causing build error

  

  Fadi Hanna

  committed
  13d6297

  Copy full SHA for 13d6297

Commits on Apr 15, 2020

• Add ValidateMethodImplRemainsInEffectAttribute validation

  Show description for ee7c507
  

  Fadi Hanna

  committed
  ee7c507

  Copy full SHA for ee7c507

• Small refactor

  

  Fadi Hanna

  committed
  06cdc5e

  Copy full SHA for 06cdc5e

• Add coverage for GVMs, and fix a validation bug with GVM instantiations

  

  Fadi Hanna

  committed
  4973022

  Copy full SHA for 4973022