Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test on windows and enable on other platforms #34331

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda commented Mar 31, 2020

The change enables test only on OpenSSL platforms.
Two years ago, the test was disabled for MacOs, however, I decided to enable it as it passes.

Contributes to #33558

@aik-jahoda
Copy link
Contributor Author

Removed macOS again. It seems mac is not still supported.

@aik-jahoda aik-jahoda requested a review from a team April 1, 2020 13:08
@aik-jahoda aik-jahoda linked an issue Apr 1, 2020 that may be closed by this pull request
2 tasks
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for fixing this.

@davidsh davidsh added this to the 5.0 milestone Apr 1, 2020
@aik-jahoda aik-jahoda merged commit 9f2b294 into dotnet:master Apr 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants