Disable warnings-as-errors for release branches #33664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
reviewed
Mar 17, 2020
|
The warnings as errors are still going to be enabled in master. This is a prep-work for when we flip PRERELEASE to 0 in release branches - it is what is going to disable warnings as errors. |
|
Ah right, I miss read the condition. |
safern
approved these changes
Mar 18, 2020
am11
reviewed
Mar 18, 2020
| @@ -13,6 +13,10 @@ elseif(CLR_CMAKE_TARGET_ARCH_ARM64) | |||
| add_definitions(-DTARGET_ARM64) | |||
| add_definitions(-DTARGET_ARMARCH) | |||
| endif() | |||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | |||
| # The ABI for passing parameters with 32-byte alignment has changed in GCC 4.6 | |||
| add_compile_options(-Wno-psabi) | |||
There was a problem hiding this comment.
@jkotas, just wondering if warning as error state for PR runs is same as before (ON), why was this special case required for GCC as master was ok without it before this PR was merged?
There was a problem hiding this comment.
The PR enabled warnings-as-errors for tests. The CoreCLR tests were built without -Werror before this change.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33627