-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate objcopy detection #33342
Conversation
@janvorli, @jkotas, can you please take a look?
|
@@ -1,4 +1,5 @@ | |||
include(CheckPIESupported) | |||
include(${CMAKE_CURRENT_LIST_DIR}/functions.cmake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we try to invoke libraries
build on unsupported platform, we get error from line 27 in this file: clr_unknown_arch
macro undefined, instead of Only AMD64, ARM64, ARM and I386 are supported
message from that function (defined in functions.cmake
). Therefore, this inclusion here makes sense (as opposed to including functions.cmake
before configureplatform.cmake
at all callsites).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! I didn't even know that we have the strip_symbols at so many places.
Thanks. There is still |
strip_destination_file
file is defined in:/eng/native/functions.cmake
, which is already included by top-level cmake scripts in coreclr, installer and libraries. This PR de-duplicates that logic and simplifies condition blocks ineng/native/configuretool.cmake
(where unified tool detection takes place).