-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable restore for ref and src projects in libraries #33242
Conversation
c7b60d4
to
0fd2476
Compare
<EnableProjectRestore Condition="'$(IsSourceProject)' == 'true' or '$(IsReferenceAssembly)' == 'true' or '$(IsTestProject)' == 'true'">true</EnableProjectRestore> | ||
</PropertyGroup> | ||
|
||
<Import Condition="'$(EnableProjectRestore)' != 'true'" Project="$(RepositoryEngineeringDir)restore\repoRestore.props" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's left using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- depproj
- pkgproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, we should try to clean up this mode, even if it means doing something slightly different for these. I was hoping to completely eliminate this hack.
Enabling project restore for ref and src projects (any by that any others as well).
@ViktorHofer 😆 🤣 |
Failure is #13295 |
This reverts commit 981cc64.
Fixes #29953
Contributes towards #31844
Upfront restore is now taking far too long, presumably because of project evaluation or multiple globs. I'm considering making restore implicit (during the build of the refs, sources and tests) so that the initial restore only handles the depproj files. Under a switch the restore target would still be able to upfront restore everything (CI mode).
Later when we removed all depproj files and sequenced everything into the build, we can remove the
-restore
action which is passed to the Arcade's Build.proj so that the-restore
action is only invoked on demand (CI or before going offline, ie airplane).Requires
cc @Anipik @joperezr @safern