Add span-based methods to Decimal #32155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabYourPitchforks
approved these changes
Feb 12, 2020
|
|
|
fyi @carlossanlop, @maryamariyan - label for "new api needs doc" missing. |
ahsonkhan
approved these changes
Feb 12, 2020
ahsonkhan
reviewed
Feb 12, 2020
...ries/System.Reflection.Metadata/src/System/Reflection/Internal/Utilities/DecimalUtilities.cs
Show resolved
Hide resolved
|
There are a few other places where we could call the new API. Did you intentionally exclude them: For example: |
Yes, two of those target netstandard2.0. The other one is a code gen tool for which we have no tests and in which such a change won't be at all measurable. |
Add missing tests
stephentoub
force-pushed
the
decimalspan
branch
from
b84c3ab to
4c7d3d0
Compare
tannergooding
approved these changes
Feb 12, 2020
stephentoub
force-pushed
the
decimalspan
branch
from
4c7d3d0 to
664a9f9
Compare
|
@ahsonkhan I haven't enabled it on the bot yet. (happens once every two days instead) |
|
@ahsonkhan I just enabled auto-labeling PRs with "new-api-needs-documentation" label. Should show up on future PRs. |
ahsonkhan
approved these changes
Feb 13, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28904
cc: @tannergooding, @GrabYourPitchforks