Fix hashing in Logging source gen

src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs

@@ -916,7 +916,8 @@ internal static int GetNonRandomizedHashCode(string s)
             {
                 result = (c ^ result) * 16777619;
             }
-            return Math.Abs((int)result);
+
+            return (int)(result & 0x7FFFFFFF); // Ensure the result is non-negative
         }
     }
 }

src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs

@@ -535,7 +535,7 @@ partial class C(ILogger logger)
                     public partial void M1();
                 }
             ");
-            
+
             Assert.Equal(2, diagnostics.Count);
 
             Assert.Equal(DiagnosticDescriptors.PrimaryConstructorParameterLoggerHidden.Id, diagnostics[0].Id);
@@ -988,6 +988,23 @@ static partial class C
             Assert.Empty(diagnostics);    // should fail quietly on broken code
         }
 
+        [Fact]
+        public async Task EventIdGenerationTest()
+        {
+            // hashing Dzoggee should not result breaking generation.
+            // in our hashing, Dzoggee result to int.MinValue before we convert it to non-negative value.
+            IReadOnlyList<Diagnostic> diagnostics = await RunGenerator(@"
+                using Microsoft.Extensions.Logging;
+                internal static partial class LoggerExtensions
+                {
+                    [LoggerMessage(Level = LogLevel.Information)]
+                    public static partial void Dzoggee(this ILogger logger);
+                }
+            ");
+
+            Assert.Empty(diagnostics);
+        }
+
         [Fact]
         internal void MultipleTypeDefinitions()
         {

src/libraries/Microsoft.Extensions.Options/gen/OptionsSourceGenContext.cs

@@ -67,17 +67,16 @@ internal static bool IsConvertibleBasicType(ITypeSymbol typeSymbol)
 
         /// <summary>
         /// Returns a non-randomized hash code for the given string.
-        /// We always return a positive value.
         /// </summary>
-        internal static int GetNonRandomizedHashCode(string s)
+        internal static uint GetNonRandomizedHashCode(string s)
         {
             uint result = 2166136261u;
             foreach (char c in s)
             {
                 result = (c ^ result) * 16777619;
             }
 
-            return Math.Abs((int)result);
+            return result;
         }
     }
 }